[SPARK-31515][SQL] Canonicalize Cast should consider the value of needTimeZone #28288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #121605 has finished for PR 28288 at commit
|
4961eb3 to
1b50047
Compare
1b50047 to
95102cc
Compare
cloud-fan
approved these changes
Apr 22, 2020
|
cc @hvanhovell |
MaxGekk
reviewed
Apr 22, 2020
Comment on lines
52
to
55
| case a: AnsiCast if !a.needsTimeZone && a.timeZoneId.nonEmpty => | ||
| a.copy(timeZoneId = None) | ||
| case c: Cast if !c.needsTimeZone && c.timeZoneId.nonEmpty => | ||
| c.copy(timeZoneId = None) |
There was a problem hiding this comment.
case c: CastBase if c.timeZoneId.nonEmpty && !c.needsTimeZone =>
c.copy(timeZoneId = None)No need to call needsTimeZone twice.
There was a problem hiding this comment.
CastBase is not a case class and can't call copy
There was a problem hiding this comment.
hmm, ok:
case c: CastBase if c.timeZoneId.nonEmpty && !c.needsTimeZone => c.withTimeZone(null)There was a problem hiding this comment.
Thanks, done in 73f4694.
|
Test build #121614 has finished for PR 28288 at commit
|
|
Test build #121629 has finished for PR 28288 at commit
|
maropu
approved these changes
Apr 23, 2020
|
retest this please |
|
Test build #121641 has finished for PR 28288 at commit
|
MaxGekk
approved these changes
Apr 23, 2020
maropu
pushed a commit
that referenced
this pull request
Apr 23, 2020
…dTimeZone ### What changes were proposed in this pull request? Override the canonicalized fields with respect to the result of `needsTimeZone`. ### Why are the changes needed? The current approach breaks sematic equal of two cast expressions that don't relate with datetime type. If we don't need to use `timeZone` information casting `from` type to `to` type, then the timeZoneId should not influence the canonicalize result. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? New UT added. Closes #28288 from xuanyuanking/SPARK-31515. Authored-by: Yuanjian Li <xyliyuanjian@gmail.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org> (cherry picked from commit ca90e19) Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
|
Thanks, all! Merged to master/3.0 |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Override the canonicalized fields with respect to the result of
needsTimeZone.Why are the changes needed?
The current approach breaks sematic equal of two cast expressions that don't relate with datetime type. If we don't need to use
timeZoneinformation castingfromtype tototype, then the timeZoneId should not influence the canonicalize result.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UT added.