Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-3829] Make Spark logo image on the header of HistoryPage as a link to HistoryPage's page #1 #2690

Closed
wants to merge 3 commits into from
Closed

[SPARK-3829] Make Spark logo image on the header of HistoryPage as a link to HistoryPage's page #1 #2690

wants to merge 3 commits into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Oct 7, 2014

There is a Spark logo on the header of HistoryPage.
We can have too many HistoryPages if we run 20+ applications. So I think, it's useful if the logo is as a link to the HistoryPage's page number 1.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have started for PR 2690 at commit dd87480.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have finished for PR 2690 at commit dd87480.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21369/Test PASSed.

@andrewor14
Copy link
Contributor

Cool! Can you post a screenshot of what this looks like?

andrewor14
andrewor14 reviewed Oct 7, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/ui/UIUtils.scala
@@ -216,8 +216,10 @@ private[spark] object UIUtils extends Logging {
<div class="row-fluid">
<div class="span12">
<h3 style="vertical-align: middle; display: inline-block;">
<img src={prependBaseUri("/static/spark-logo-77x50px-hd.png")}
style="margin-right: 15px;" />
<a style="text-decoration: none" href ={prependBaseUri("/")}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no space before href

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have started for PR 2690 at commit 908c109.

  • This patch merges cleanly.

@sarutak
Copy link
Member Author

sarutak commented Oct 7, 2014

Thanks for picking up this PR @andrewor14 !
These are the screen shots.

If we are in page 1+, and click the Spark log on the header of the page, then ...
2014-10-08 7 46 47

We can go to the page 1.
2014-10-08 7 47 20

@andrewor14
Copy link
Contributor

Oh whoops, in retrospect it seems that there are actually no changes in terms of appearance. Sorry for making you post the screenshots. This LGTM. Merging when tests pass.

@sarutak
Copy link
Member Author

sarutak commented Oct 7, 2014

Yeah, just made the logo as a link.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have finished for PR 2690 at commit 908c109.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21416/Test PASSed.

@asfgit asfgit closed this in b69c9fb Oct 7, 2014
asfgit pushed a commit that referenced this pull request Oct 7, 2014
@sarutak @andrewor14
[SPARK-3829] Make Spark logo image on the header of HistoryPage as a …
a1f833f 
…link to HistoryPage's page #1

There is a Spark logo on the header of HistoryPage.
We can have too many HistoryPages if we run 20+ applications. So I think, it's useful if the logo is as a link to the HistoryPage's page number 1.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #2690 from sarutak/SPARK-3829 and squashes the following commits:

908c109 [Kousuke Saruta] Removed extra space.
00bfbd7 [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark into SPARK-3829
dd87480 [Kousuke Saruta] Made header Spark log image as a link to History Server's top page.

(cherry picked from commit b69c9fb)
Signed-off-by: Andrew Or <andrewor14@gmail.com>
@sarutak sarutak deleted the SPARK-3829 branch April 11, 2015 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarutak @SparkQA @AmplabJenkins @andrewor14