Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-3639 | Removed settings master in examples #2536

Closed
wants to merge 3 commits into from
Closed

SPARK-3639 | Removed settings master in examples #2536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31cdc59
SPARK-3639 | Removed settings master in examples
aniketbhatnagar Sep 25, 2014
fec8ead
SPARK-3639 | Removed settings master in examples
aniketbhatnagar Sep 25, 2014
c9723ac
Merge remote-tracking branch 'origin/Kinesis-Examples-Master-Unset' i…
aniketbhatnagar Sep 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ...inesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@
* org.apache.spark.examples.streaming.JavaKinesisWordCountASL mySparkStream \
* https://kinesis.us-east-1.amazonaws.com
*
* Note that number of workers/threads should be 1 more thread than the number of receivers.
* This leaves one thread available for actually processing the data.
*
* There is a companion helper class called KinesisWordCountProducerASL which puts dummy data
* onto the Kinesis stream.
* Usage instructions for KinesisWordCountProducerASL are provided in the class definition.
Expand Down Expand Up @@ -114,12 +117,8 @@ public static void main(String[] args) {
/* In this example, we're going to create 1 Kinesis Worker/Receiver/DStream for each shard */
int numStreams = numShards;

/* Must add 1 more thread than the number of receivers or the output won't show properly from the driver */
int numSparkThreads = numStreams + 1;

/* Setup the Spark config. */
SparkConf sparkConfig = new SparkConf().setAppName("KinesisWordCount").setMaster(
"local[" + numSparkThreads + "]");
SparkConf sparkConfig = new SparkConf().setAppName("KinesisWordCount");

/* Kinesis checkpoint interval. Same as batchInterval for this example. */
Duration checkpointInterval = batchInterval;
Expand Down
13 changes: 6 additions & 7 deletions .../kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ import org.apache.log4j.Level
* org.apache.spark.examples.streaming.KinesisWordCountASL mySparkStream \
* https://kinesis.us-east-1.amazonaws.com
*
*
* Note that number of workers/threads should be 1 more thread than the number of receivers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"should be 1 more than the number of receivers"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean this example can't run with --master local?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this example may not run with --master local if number of cores in the machine are not more than number of shards in the Kinesis stream. I think this is fine because same is the case when running in the standalone or yarn cluster

* This leaves one thread available for actually processing the data.
*
* There is a companion helper class below called KinesisWordCountProducerASL which puts
* dummy data onto the Kinesis stream.
* Usage instructions for KinesisWordCountProducerASL are provided in that class definition.
Expand Down Expand Up @@ -97,17 +101,12 @@ private object KinesisWordCountASL extends Logging {
/* In this example, we're going to create 1 Kinesis Worker/Receiver/DStream for each shard. */
val numStreams = numShards

/*
* numSparkThreads should be 1 more thread than the number of receivers.
* This leaves one thread available for actually processing the data.
*/
val numSparkThreads = numStreams + 1


/* Setup the and SparkConfig and StreamingContext */
/* Spark Streaming batch interval */
val batchInterval = Milliseconds(2000)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove random new lines here?

val sparkConfig = new SparkConf().setAppName("KinesisWordCount")
.setMaster(s"local[$numSparkThreads]")
val ssc = new StreamingContext(sparkConfig, batchInterval)

/* Kinesis checkpoint interval. Same as batchInterval for this example. */
Expand Down