Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARK-3639 | Removed settings master in examples #2536

Closed
wants to merge 3 commits into from
Closed

SPARK-3639 | Removed settings master in examples #2536

wants to merge 3 commits into from

Conversation

aniketbhatnagar
Copy link
Contributor

This patch removes setting of master as local in Kinesis examples so that users can set it using submit-job.

@aniketbhatnagar
SPARK-3639 | Removed settings master in examples
31cdc59 
This patch removes setting of master as local in Kinesis examples so
that users can set it using submit-job.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

andrewor14
andrewor14 reviewed Sep 25, 2014
View reviewed changes
extras/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
/* Setup the and SparkConfig and StreamingContext */
/* Spark Streaming batch interval */
val batchInterval = Milliseconds(2000)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove random new lines here?

@andrewor14
Copy link
Contributor

ok to test. If tests pass this LGTM.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have started for PR 2536 at commit 31cdc59.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have finished for PR 2536 at commit 31cdc59.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20818/

@aniketbhatnagar
SPARK-3639 | Removed settings master in examples
fec8ead 
This patch removes setting of master as local in Kinesis examples so
that users can set it using submit-job.
@aniketbhatnagar
Merge remote-tracking branch 'origin/Kinesis-Examples-Master-Unset' i…
c9723ac 
…nto Kinesis-Examples-Master-Unset

Conflicts:
	extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
	extras/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2536 at commit c9723ac.

  • This patch merges cleanly.

@aniketbhatnagar
Copy link
Contributor Author

@andrewor14 thanks for reviewing this. All review comments have been incorporated. Please review once again.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2536 at commit c9723ac.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20847/

@andrewor14
Copy link
Contributor

Ok I'm merging this into master and 1.1. Thanks.

asfgit pushed a commit that referenced this pull request Sep 26, 2014
@aniketbhatnagar @andrewor14
SPARK-3639 | Removed settings master in examples
d6ed5ab 
This patch removes setting of master as local in Kinesis examples so that users can set it using submit-job.

Author: aniketbhatnagar <aniket.bhatnagar@gmail.com>

Closes #2536 from aniketbhatnagar/Kinesis-Examples-Master-Unset and squashes the following commits:

c9723ac [aniketbhatnagar] Merge remote-tracking branch 'origin/Kinesis-Examples-Master-Unset' into Kinesis-Examples-Master-Unset
fec8ead [aniketbhatnagar] SPARK-3639 | Removed settings master in examples
31cdc59 [aniketbhatnagar] SPARK-3639 | Removed settings master in examples

(cherry picked from commit d16e161)
Signed-off-by: Andrew Or <andrewor14@gmail.com>
@asfgit asfgit closed this in d16e161 Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aniketbhatnagar @AmplabJenkins @andrewor14 @SparkQA