-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-1087] Move python traceback utilities into new traceback_utils.py file. #2385
Conversation
Can one of the admins verify this patch? |
Jenkins, this is ok to test. |
QA tests have started for PR 2385 at commit
|
LGTM. |
QA tests have finished for PR 2385 at commit
|
Hi, the above failure in NetworkReceiverSuite.scala seems like it may be unrelated to this patch. That test also passed when I ran locally. |
QA tests have started for PR 2385 at commit
|
QA tests have finished for PR 2385 at commit
|
if rdd._extract_concise_traceback() is not None: | ||
self._callsite = rdd._extract_concise_traceback() | ||
if extract_concise_traceback() is not None: | ||
self._callsite = extract_concise_traceback() | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to only call extract_concise_traceback() once, such as:
self._callsite = extract_concise_traceback()
if self._callsite is None:
xxxx
LGTM, just one minor comment, it's not must to have. |
import traceback | ||
|
||
|
||
__all__ = ["extract_concise_traceback", "SparkContext"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I also need to put JavaStackTrace here instead of SparkContext.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are just internal interfaces, so it's fine to not have all here. If having, it should be JavaStackTrace
Hi - I addressed the review comments and made some additional cosmetic changes. |
QA tests have started for PR 2385 at commit
|
QA tests have finished for PR 2385 at commit
|
This looks good to me, so I'm going to merge it. Thanks! |
Great! Thanks to all the reviewers. |
Also made some cosmetic cleanups.