Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLLIB] minor update to word2vec #2043

Closed
wants to merge 2 commits into from
Closed

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Aug 19, 2014

very minor update @Ishiihara

@Ishiihara
Copy link
Contributor

Looks good to me.

@mengxr
Copy link
Contributor Author

mengxr commented Aug 19, 2014

@Ishiihara I added more changes. We don't need synOut to be a map.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 2043 at commit be649fd.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 2043 at commit be649fd.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor Author

mengxr commented Aug 19, 2014

Jenkins, retest this please.

@mengxr
Copy link
Contributor Author

mengxr commented Aug 19, 2014

The Jenkins working folder is not clean.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 2043 at commit be649fd.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have finished for PR 2043 at commit be649fd.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Aug 20, 2014
very minor update Ishiihara

Author: Xiangrui Meng <meng@databricks.com>

Closes #2043 from mengxr/minor-w2v and squashes the following commits:

be649fd [Xiangrui Meng] remove map because we only need append
eccefcc [Xiangrui Meng] minor updates to word2vec

(cherry picked from commit 1870dba)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 1870dba Aug 20, 2014
@mengxr
Copy link
Contributor Author

mengxr commented Aug 20, 2014

I've merged this into master and branch-1.1.

asfgit pushed a commit that referenced this pull request Aug 20, 2014
Sorry I didn't realize this in #2043. Ishiihara

Author: Xiangrui Meng <meng@databricks.com>

Closes #2049 from mengxr/more-w2v and squashes the following commits:

050b1c5 [Xiangrui Meng] output shuffle data directly

(cherry picked from commit 0a984aa)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
asfgit pushed a commit that referenced this pull request Aug 20, 2014
Sorry I didn't realize this in #2043. Ishiihara

Author: Xiangrui Meng <meng@databricks.com>

Closes #2049 from mengxr/more-w2v and squashes the following commits:

050b1c5 [Xiangrui Meng] output shuffle data directly
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
very minor update Ishiihara

Author: Xiangrui Meng <meng@databricks.com>

Closes apache#2043 from mengxr/minor-w2v and squashes the following commits:

be649fd [Xiangrui Meng] remove map because we only need append
eccefcc [Xiangrui Meng] minor updates to word2vec
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Sorry I didn't realize this in apache#2043. Ishiihara

Author: Xiangrui Meng <meng@databricks.com>

Closes apache#2049 from mengxr/more-w2v and squashes the following commits:

050b1c5 [Xiangrui Meng] output shuffle data directly
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Sep 24, 2024
)

Co-authored-by: Steve Vaughan Jr <s_vaughan@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants