-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-21060][WEB-UI]Css style about paging function is error in the executor page. Css style about paging function is error in the executor page. It is different of history server ui paging function css style. #18275
Conversation
…ucceeded|failed|unknown]
…remove redundant description.
I tend to take your word, but will CC @ajbozarth just in case. (BTW why do your PRs have a huge number of merge commits? you generally branch off a clean fork of |
I know, is not it a bug or an improvement corresponding to a branch? This also makes it easy for you to merge to master.@srowen |
I'm sorry, I do not understand what you said, can you elaborate on it? |
Look at all the "Merge branch 'master'..." messages above. I think you're somehow branching off a branch that you keep merging from upstream master. You just need to keep your |
@ajbozarth |
No @guoxiaolongzte I think it's an issue with the branch you have set up to track upstream |
Test build #3790 has finished for PR 18275 at commit
|
Test build #3792 has finished for PR 18275 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@srowen |
Test build #3794 has finished for PR 18275 at commit
|
Merged to master/2.2 |
… executor page. Css style about paging function is error in the executor page. It is different of history server ui paging function css style. ## What changes were proposed in this pull request? Css style about paging function is error in the executor page. It is different of history server ui paging function css style. **But their style should be consistent**. There are three reasons. 1. The first reason: 'Previous', 'Next' and number should be the button format. 2. The second reason: when you are on the first page, 'Previous' and '1' should be gray and can not be clicked.  3. The third reason: when you are on the last page, 'Previous' and 'Max number' should be gray and can not be clicked.  before fix:  after fix:  The style of history server ui:  ## How was this patch tested? manual tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: guoxiaolong <guo.xiaolong1@zte.com.cn> Author: 郭小龙 10207633 <guo.xiaolong1@zte.com.cn> Author: guoxiaolongzte <guo.xiaolong1@zte.com.cn> Closes #18275 from guoxiaolongzte/SPARK-21060. (cherry picked from commit b7304f2) Signed-off-by: Sean Owen <sowen@cloudera.com>
… executor page. Css style about paging function is error in the executor page. It is different of history server ui paging function css style. ## What changes were proposed in this pull request? Css style about paging function is error in the executor page. It is different of history server ui paging function css style. **But their style should be consistent**. There are three reasons. 1. The first reason: 'Previous', 'Next' and number should be the button format. 2. The second reason: when you are on the first page, 'Previous' and '1' should be gray and can not be clicked.  3. The third reason: when you are on the last page, 'Previous' and 'Max number' should be gray and can not be clicked.  before fix:  after fix:  The style of history server ui:  ## How was this patch tested? manual tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: guoxiaolong <guo.xiaolong1@zte.com.cn> Author: 郭小龙 10207633 <guo.xiaolong1@zte.com.cn> Author: guoxiaolongzte <guo.xiaolong1@zte.com.cn> Closes apache#18275 from guoxiaolongzte/SPARK-21060.
What changes were proposed in this pull request?
Css style about paging function is error in the executor page. It is different of history server ui paging function css style.
But their style should be consistent. There are three reasons.
The first reason: 'Previous', 'Next' and number should be the button format.
The second reason: when you are on the first page, 'Previous' and '1' should be gray and can not be clicked.

The third reason: when you are on the last page, 'Previous' and 'Max number' should be gray and can not be clicked.

before fix:

after fix:

The style of history server ui:

How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.