Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2888] [SQL] Fix addColumnMetadataToConf in HiveTableScan #1817

Closed
wants to merge 1 commit into from
Closed

[SPARK-2888] [SQL] Fix addColumnMetadataToConf in HiveTableScan #1817

wants to merge 1 commit into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Aug 6, 2014

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1817. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18070/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1817:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18070/consoleFull

@marmbrus
Copy link
Contributor

marmbrus commented Aug 8, 2014

Does it make sense to merge this? Into 1.1?

@yhuai yhuai changed the title [SPARK-2888] [SQL] Fix fixAddColumnMetadataToConf in HiveTableScan [SPARK-2888] [SQL] Fix addColumnMetadataToConf in HiveTableScan Aug 8, 2014
@yhuai
Copy link
Contributor Author

yhuai commented Aug 8, 2014

Yeah. I think it makes sense to merge it.

A quick summary. This PR has two main changes.
First, instead of generating internal column names with

val columnInternalNames = neededColumnIDs.map(HiveConf.getColumnInternalName(_)).mkString(",")

We use

relation.attributes.map(_.name).mkString(",")

Second, we always set needed column ids instead of ill defined setFullyReadColumns.

@asfgit asfgit closed this in 9016af3 Aug 8, 2014
asfgit pushed a commit that referenced this pull request Aug 8, 2014
@yhuai @marmbrus
[SPARK-2888] [SQL] Fix addColumnMetadataToConf in HiveTableScan
3eb5dd0 
JIRA: https://issues.apache.org/jira/browse/SPARK-2888

Author: Yin Huai <huai@cse.ohio-state.edu>

Closes #1817 from yhuai/fixAddColumnMetadataToConf and squashes the following commits:

fba728c [Yin Huai] Fix addColumnMetadataToConf.

(cherry picked from commit 9016af3)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus
Copy link
Contributor

marmbrus commented Aug 8, 2014

Thanks! merged to master and 1.1.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@yhuai @conviva-zz
[SPARK-2888] [SQL] Fix addColumnMetadataToConf in HiveTableScan
57d7854 
JIRA: https://issues.apache.org/jira/browse/SPARK-2888

Author: Yin Huai <huai@cse.ohio-state.edu>

Closes apache#1817 from yhuai/fixAddColumnMetadataToConf and squashes the following commits:

fba728c [Yin Huai] Fix addColumnMetadataToConf.
@yhuai yhuai deleted the fixAddColumnMetadataToConf branch October 6, 2014 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhuai @SparkQA @marmbrus