[Spark-2381] stop the streaming application if the receiver job failed #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can you please add unit test for this change. |
|
Also could you change the title to contain "SPARK-2381" (withi -) |
|
Ok, I'll do it soon |
|
Jenkins, this is ok to test. |
|
@joyyoj Can you please add an unit test for this behavior in the StremaingContextSuite, this is a significant change in the program behavior and should have a unit test. |
| try { | ||
| ssc.sparkContext.runJob(tempRDD, startReceiver) | ||
| } catch { | ||
| case e : Throwable => |
There was a problem hiding this comment.
Scala uses throwable for control flow, so throwable should never be caught in a Scala program. Please catch Exception
|
Can one of the admins verify this patch? |
|
@joyyoj any updates on this? |
|
@joyyoj If you are unable to address the comments on this PR, mind closing this? |
| logError("receiver job crashed, detail:" + e.getStackTraceString) | ||
| // find a better way to stop the application ? make other stages depend on tempRdd ? | ||
| ssc.stop() | ||
| System.exit(1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.