-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-2714] DAGScheduler logs jobid when runJob finishes #1617
Conversation
Can one of the admins verify this patch? |
What is the need to expose the jobId after the job is finished? |
Hi @markhamstra When DAGScheduler concurrently runs multiple jobs, SparkContext only logs "Job finished" and logs in the same file which doesn't tell who is who. It's difficult to found which job has finished or how much time it has taken from multiple "Job finished: ..., took ... s" logs. |
ok to test |
logInfo( | ||
"Job " + waiter.jobId + " finished: " + callSite.shortForm + | ||
", took " + (System.nanoTime - start) / 1e9 + " s") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do string formatting instead to make this more readable:
logInfo("Job %d finished: %s, took %ds".format(
(waiter.jobId, callSite.shortForm, (System.nanoTime - start) / 1e9))
QA tests have started for PR 1617 at commit
|
QA tests have finished for PR 1617 at commit
|
QA tests have started for PR 1617 at commit
|
@andrewor14 Thanks. Please review again. |
QA tests have started for PR 1617 at commit
|
Tests timed out after a configured wait of |
Tests timed out after a configured wait of |
case JobFailed(exception: Exception) => | ||
logInfo("Failed to run " + callSite.shortForm) | ||
logInfo("Job %d failed: %s, took %d s".format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, the last one has to be %f
, here and in L431
QA tests have started for PR 1617 at commit
|
QA tests have finished for PR 1617 at commit
|
Thanks, merging this into master. |
This upgrades Boson to 0.2.7-beta. [Release notes](https://github.pie.apple.com/pie/boson/releases/tag/0.2.7-beta).
DAGScheduler logs jobid when runJob finishes