New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

是不是不接受没有单元测试的bugfix比较合理 #554

Closed

neil4dong opened this issue Jan 15, 2018 · 1 comment

Labels

type: discussion

Contributor

neil4dong commented Jan 15, 2018

在release 文档中出现有些问题：https://github.com/shardingjdbc/sharding-jdbc/blob/dev/RELEASE-NOTES.md

#308
在修复后，过了一两个小版本就只就出现了同一个地方的问题。
#356
这个100%是没有单元测试导致的。

建议是否可以采用mysql-jdbc-connector的单元测试，去掉不明确不支持的部分。
sharding-jdbc在使用以来最大的感受就是，问题比较多，已经报告了好几个不过了。
祝越来越好

Member

terrymanu commented Jan 15, 2018

谢谢建议。
我们会尽量写单元测试，目前测试覆盖率80%以上，应该是已知开源项目中测试覆盖率比较高的（大部分都是20%）
我们未来也会对代码更多的单元测试

terrymanu closed this as completed

terrymanu added the type: discussion label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment