Skip to content

Commit

Permalink
[ISSUE #610] fix setRequestTimeout use Duration.ofDays (#621)
Browse files Browse the repository at this point in the history
Co-authored-by: rongtong <jinrongtong5@163.com>
  • Loading branch information
panzhi33 and RongtongJin authored Feb 9, 2024
1 parent 89896c5 commit 251a53e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ private SimpleConsumerBuilder createConsumer(org.apache.rocketmq.client.annotati
String endPoints = resolvePlaceholders(annotation.endpoints(), simpleConsumer.getEndpoints());
String tag = resolvePlaceholders(annotation.tag(), simpleConsumer.getTag());
String filterExpressionType = resolvePlaceholders(annotation.filterExpressionType(), simpleConsumer.getFilterExpressionType());
Duration requestTimeout = Duration.ofDays(annotation.requestTimeout());
Duration requestTimeout = Duration.ofSeconds(annotation.requestTimeout());
int awaitDuration = annotation.awaitDuration();
Boolean sslEnabled = simpleConsumer.isSslEnabled();
Assert.hasText(topicName, "[topic] must not be null");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ private ProducerBuilder createProducer(ExtProducerResetConfiguration annotation)
secretKey = StringUtils.hasLength(secretKey) ? secretKey : producerConfig.getSecretKey();
int requestTimeout = annotation.requestTimeout();
Boolean sslEnabled = producerConfig.isSslEnabled();
ClientConfiguration clientConfiguration = RocketMQUtil.createClientConfiguration(accessKey, secretKey, endpoints, Duration.ofDays(requestTimeout), sslEnabled);
ClientConfiguration clientConfiguration = RocketMQUtil.createClientConfiguration(accessKey, secretKey, endpoints, Duration.ofSeconds(requestTimeout), sslEnabled);
final ClientServiceProvider provider = ClientServiceProvider.loadService();
ProducerBuilder producerBuilder = provider.newProducerBuilder()
.setClientConfiguration(clientConfiguration).setMaxAttempts(annotation.maxAttempts())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ private DefaultListenerContainer createRocketMQListenerContainer(String name, Ob
container.setTag(environment.resolvePlaceholders(annotation.tag()));
container.setEndpoints(environment.resolvePlaceholders(annotation.endpoints()));
container.setTopic(environment.resolvePlaceholders(annotation.topic()));
container.setRequestTimeout(Duration.ofDays(annotation.requestTimeout()));
container.setRequestTimeout(Duration.ofSeconds(annotation.requestTimeout()));
container.setMaxCachedMessageCount(annotation.maxCachedMessageCount());
container.setConsumptionThreadCount(annotation.consumptionThreadCount());
container.setMaxCacheMessageSizeInBytes(annotation.maxCacheMessageSizeInBytes());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public static ClientConfiguration createProducerClientConfiguration(RocketMQProp
String accessKey = rocketMQProducer.getAccessKey();
String secretKey = rocketMQProducer.getSecretKey();
String endPoints = rocketMQProducer.getEndpoints();
Duration requestTimeout = Duration.ofDays(rocketMQProducer.getRequestTimeout());
Duration requestTimeout = Duration.ofSeconds(rocketMQProducer.getRequestTimeout());
boolean sslEnabled = rocketMQProducer.isSslEnabled();
return createClientConfiguration(accessKey, secretKey, endPoints, requestTimeout, sslEnabled);
}
Expand All @@ -129,7 +129,7 @@ public static ClientConfiguration createConsumerClientConfiguration(RocketMQProp
String accessKey = simpleConsumer.getAccessKey();
String secretKey = simpleConsumer.getSecretKey();
String endPoints = simpleConsumer.getEndpoints();
Duration requestTimeout = Duration.ofDays(simpleConsumer.getRequestTimeout());
Duration requestTimeout = Duration.ofSeconds(simpleConsumer.getRequestTimeout());
boolean sslEnabled = simpleConsumer.isSslEnabled();
return createClientConfiguration(accessKey, secretKey, endPoints, requestTimeout, sslEnabled);

Expand Down

0 comments on commit 251a53e

Please sign in to comment.