-
Notifications
You must be signed in to change notification settings - Fork 202
Comparing changes
Open a pull request
base repository: apache/polaris
base: main
head repository: apache/polaris
compare: persistence-poc
- 16 commits
- 36 files changed
- 1 contributor
Commits on Feb 24, 2025
-
Remove all tightly coupled EntityCache dependencies in the main persi…
…stence stack Remove the EntityCacheEntry wrapper since the timestamp fields were never used anyways; instead the underlying Caffeine cache transparently handles access times, and the types of entries we cache are simply the existing ResolvedPolarisEntity. Remove interactions of business logic with explicit "cache entries", instead operating on ResolvedPolarisEntity. Fix the equals()/hashCode() behavior of PolarisEntity to be compatible with PolarisBaseEntity as intended. Improve code comments to explain the (current) relationship between PolarisEntity and PolarisBaseEntity, and clarify the behaviors in Resolver.java. Fully remove the PolarisRemoteCache interface and its methods. Add different methods that aren't cache-specific instead.
Configuration menu - View commit details
-
Copy full SHA for efbb666 - Browse repository at this point
Copy the full SHA efbb666View commit details -
Add support for actually giving null EntityCache to Resolver; paramet…
…erize ResolverTest
Configuration menu - View commit details
-
Copy full SHA for 04a636e - Browse repository at this point
Copy the full SHA 04a636eView commit details -
Remove PolarisMetaStoreSession from FileIOFactory/FileIOUtil in favor…
… of CallContext This appeared to be some leaky divergence that occurred after CallContext had been removed, but PolarisMetaStoreSession really is only a low-level implementation detail that should never be handled by BasePolarisCatalog/FileIOFactory. This plumbs CallContext explicitly into the FileIOFactory and FileIOUtil methods and thus removes a large source of CallContext.getCurrentContext calls; now the threadlocal doesn't have to be set at all in BasePolarisCatalogTest.
Configuration menu - View commit details
-
Copy full SHA for 31a837b - Browse repository at this point
Copy the full SHA 31a837bView commit details
Commits on Feb 25, 2025
-
Configuration menu - View commit details
-
Copy full SHA for dc820d7 - Browse repository at this point
Copy the full SHA dc820d7View commit details -
Restructure persistence class hierarchy and remove vestigial interfaces
Extract a basic abstract base class BaseMetaStoreManager which can hold shared logic between implementations of PolarisMetaStoreManager
Configuration menu - View commit details
-
Copy full SHA for 7d8942f - Browse repository at this point
Copy the full SHA 7d8942fView commit details -
Remove all "entitiesDropped" members; these were vestigial from tryin…
…g to implement UNDROP but for now are entirely unused. We can reintroduce it with a better design against multiple backends when/if we want to implement UNDROP.
Configuration menu - View commit details
-
Copy full SHA for 54b762e - Browse repository at this point
Copy the full SHA 54b762eView commit details -
Extract BasePersistence interface as parent interface of PolarisMetaS…
…toreSession; only leave the transaction-specific methods in PolarisMetaStoreSession
Configuration menu - View commit details
-
Copy full SHA for c7c9c45 - Browse repository at this point
Copy the full SHA c7c9c45View commit details
Commits on Feb 26, 2025
-
Merge branch 'main' of github.com:dennishuo/polaris into dhuo-persist…
…ence-poc-extract-abstract-base
Configuration menu - View commit details
-
Copy full SHA for db9e71d - Browse repository at this point
Copy the full SHA db9e71dView commit details -
Push all evidence of the two-phase lookupEntityByName into only the t…
…ransactional-style PolarisMetaStoreSession, so that BasePersistence properly exposes a lookupEntityByName method where impls that use secondary indexes can easily just lookup an entity by name instead of doing two lookups.
Configuration menu - View commit details
-
Copy full SHA for 87a8010 - Browse repository at this point
Copy the full SHA 87a8010View commit details -
Turn PolarisMetaStoreSession into an abstract class and make lookupEn…
…tityActive protected-visibility; remove all callsites where PolarisMetaStoreManagerImpl calls it. Technically, while in the same package this doesn't prevent it from leaking, but we could reposition PolarisMetaStoreSession into a separate transaction-specific package to help protect it from leaking the lower-level abstractions.
Configuration menu - View commit details
-
Copy full SHA for 13ba161 - Browse repository at this point
Copy the full SHA 13ba161View commit details -
Pushdown all calls to writeToEntities into PolarisMetaStoreSession, a…
…nd add writeEntity method to BasePersistence, with a default impl in PolarisMetaStoreSession containing what was previously in PolarisMetaStoreManagerImpl. This now protects all writes in PolarisMetaStoreManagerImpl from dealing with the three-table implementation detail. Technically slightly changes the ordering of updates within a transaction for renameEntity, but is arguably a more correct ordering, and the ordering doesn't interleave reads anyways.
Configuration menu - View commit details
-
Copy full SHA for 5743dd2 - Browse repository at this point
Copy the full SHA 5743dd2View commit details -
Add originalEntity to the writeEntity method to enable compare-and-sw…
…ap behavior from the underlying BasePersistence. Pushdown all the deleteFromEntities* methods into PolarisMetaStoreSession and add deleteEntity to BasePersistence which encapsulates handling the separate slices.
Configuration menu - View commit details
-
Copy full SHA for b739fd1 - Browse repository at this point
Copy the full SHA b739fd1View commit details -
Break out external-integration related methods from BasePersistence i…
…nto a new IntegrationPersistence interface; these methods encapsulate certain type-specific behaviors that are indirectly tied to persistence entities, such as principal secrets, storage integrations, etc.
Configuration menu - View commit details
-
Copy full SHA for b52a4af - Browse repository at this point
Copy the full SHA b52a4afView commit details
Commits on Feb 27, 2025
-
Improve javadoc comments, rename PolarisEntityActiveRecord to EntityN…
…ameLookupRecord, remove unused method
Configuration menu - View commit details
-
Copy full SHA for f9c1fd7 - Browse repository at this point
Copy the full SHA f9c1fd7View commit details -
Rename PolarisMetaStoreSession to TransactionalPersistence and move i…
…nto a new package "transactional".
Configuration menu - View commit details
-
Copy full SHA for f0f06ad - Browse repository at this point
Copy the full SHA f0f06adView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea0a90f - Browse repository at this point
Copy the full SHA ea0a90fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...persistence-poc