Skip to content

Commit 2c67329

Browse files
authored
Group application.properties by build time / run time (#970)
1 parent 44d7799 commit 2c67329

File tree

3 files changed

+29
-11
lines changed

3 files changed

+29
-11
lines changed

quarkus/admin/src/main/resources/application.properties

+8
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
# under the License.
1818
#
1919

20+
# ---- Build-time configuration ----
21+
# Build-time properties take effect when Quarkus processes java classes
22+
# and creates Polaris jars. These properties cannot be overriden in runtime.
23+
# Cf. https://quarkus.io/guides/all-config
24+
2025
quarkus.application.name=Apache Polaris Admin Tool (incubating)
2126
quarkus.banner.path=/org/apache/polaris/admintool/banner.txt
2227

@@ -27,4 +32,7 @@ quarkus.container-image.group=apache
2732
quarkus.container-image.name=polaris-admin-tool
2833
quarkus.container-image.additional-tags=latest
2934

35+
# ---- Runtime Configuration ----
36+
# Below are default values for properties that can be changed in runtime.
37+
3038
polaris.persistence.type=eclipse-link

quarkus/defaults/src/main/resources/application.properties

+16-11
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,30 @@
1717
# under the License.
1818
#
1919

20+
# ---- Build-time configuration ----
21+
# Build-time properties take effect when Quarkus processes java classes
22+
# and creates Polaris jars. These properties cannot be overriden in runtime.
23+
# Cf. https://quarkus.io/guides/all-config
24+
2025
quarkus.banner.path=/org/apache/polaris/service/banner.txt
26+
quarkus.http.auth.basic=false
27+
quarkus.http.enable-compression=true
28+
quarkus.http.enable-decompression=true
29+
quarkus.http.compress-media-types=application/json,text/html,text/plain
30+
quarkus.management.enabled=true
31+
quarkus.micrometer.enabled=true
32+
quarkus.micrometer.export.prometheus.enabled=true
33+
quarkus.otel.enabled=true
34+
35+
# ---- Runtime Configuration ----
36+
# Below are default values for properties that can be changed in runtime.
2137

2238
quarkus.config.mapping.validate-unknown=true
2339

24-
quarkus.http.auth.basic=false
2540
quarkus.http.access-log.enabled=true
2641
# quarkus.http.access-log.pattern=common
27-
quarkus.http.enable-compression=true
28-
quarkus.http.enable-decompression=true
2942
quarkus.http.body.handle-file-uploads=false
3043
quarkus.http.limits.max-body-size=10240K
31-
quarkus.http.compress-media-types=application/json,text/html,text/plain
3244

3345
quarkus.http.cors.origins=http://localhost:8080
3446
quarkus.http.cors.methods=PATCH, POST, DELETE, GET, PUT
@@ -57,16 +69,9 @@ quarkus.log.category."org.apache.polaris".level=INFO
5769
quarkus.log.category."org.apache.iceberg.rest".level=INFO
5870
quarkus.log.category."io.smallrye.config".level=INFO
5971

60-
quarkus.management.enabled=true
6172
quarkus.management.port=8182
6273
quarkus.management.test-port=0
6374

64-
quarkus.micrometer.enabled=true
65-
quarkus.micrometer.export.prometheus.enabled=true
66-
67-
# quarkus.otel.enabled is a build-time property. If it is disabled at build time, it will not be
68-
# possible to reset it at runtime, consequently all OTel functionality will be disabled.
69-
quarkus.otel.enabled=true
7075
# quarkus.otel.sdk.disabled is set to `true` by default to avoid spuriour errors about
7176
# trace collector connections being impossible to establish. This setting can be enabled
7277
# at runtime after configuring other OTel properties for proper trace data collection.

quarkus/server/src/main/resources/application.properties

+5
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
# under the License.
1818
#
1919

20+
# ---- Build-time configuration ----
21+
# Build-time properties take effect when Quarkus processes java classes
22+
# and creates Polaris jars. These properties cannot be overriden in runtime.
23+
# Cf. https://quarkus.io/guides/all-config
24+
2025
quarkus.application.name=Apache Polaris Server (incubating)
2126

2227
quarkus.container-image.build=false

0 commit comments

Comments
 (0)