-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Google Analytics from Maven Website #660
Comments
Hi @niallkp |
Hi @hboutemy , thanks for the response! I've added a column to the table above indicating a later minor version (theres 27 of them) - so if you could get agreement to delete those, that would be a start. There are also six maven plugins where the LATEST version has Google Analytics and I was wondering whether they need patches to ensure the next release doesn't contain GA or whether thats already been fixed?
I've become quite adept at doing search/replace to remove GA, so happy to help generate patches if you want - let me know. |
@niallkp most of the cleanup done can you check and report, please, what issues remain? It should be much much less now |
Sorry @hboutemy I messed up. When I checked the maven website out of SVN, I didn't notice it had timed out - so I had only a part of the website locally. So instead of there being 6,000+ files with GA, there are actually 52,000+ files. Thanks for doing the cleanup of minor versions, it has removed some GA. I have updated the list in the description to reflect the current situation. There are a few maven components with later minor versions in the current list which could also be removed, but it still leaves a daunting list of docs to fix
|
Isn't it enough to rely on the ASF CSP to disable Google Analytics for the archived sites? |
@hboutemy can you share somewhere your commands or script used to cleanups? |
VS Code search replace... |
for sparse checkout, ignoring big content like javadoc and jxr, I did a small
then in the directory, I search replace with VS Code and svn commit the result like what I just did:
human judgement is useful for searching for google-analytics and iteratively extracting all misc corresponding snippets |
@niallkp I think it is all done: can you check please and confirm? |
Wow @hboutemy, thats brilliant - thanks for doing that! I re-scanned the Doxia website which was all clear. For the Maven website I only found 16 pages still with Google Analytics - in the ref/4.0.0-alpha-3/maven-bom component. I'm attaching a patch to fix that, relative to the following path: The patch also changes the docs in the maven-site-plugin to use a different js example other than Google Analytics - but that isn't an issue, except it will prevent a false positive on the report to the Privacy Committee - so feel free to not apply that part. |
Bug description
Hi Maven Team!
Its great that you've migrated from Google Analytics (GA) to Matomo - thanks for doing that. However there seems to be a large number of pages (52,000+)in old docs that still have GA. The table below shows which components/versions are affected & the number of files containing GA.
I'm not sure what the best way is to resolve this and I guess there might be different solutions for different components. I'm prepared to help with the work, but perhaps someone could do a triage what the best course of action is for each component?
Regards
Niall
Maven site URL where bug exists
x
The text was updated successfully, but these errors were encountered: