-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we make DaciukMihovAutomatonBuilder
pkg-private?
#12321
Labels
Comments
Oooh I love that idea! |
Thanks @mikemccand. I'll take this up after #12320, unless someone else jumps on it first. I'd like to keep it separate from the changes in #12320 to avoid putting too much in one PR. |
nice idea! |
Yes, yes, yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There's some good suggestions/discussion around renaming this class in #12310, but I wonder if we should consider making it pkg-private and exposing the
build
functionality throughAutomata
instead? We already do this withAutomata#makeStringUnion
, so maybe we could shrink our API footprint and consolidate everything behindAutomata
?The text was updated successfully, but these errors were encountered: