Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DaciukMihovAutomatonBuilder#build should probably take a List instead of a Collection #12319

Closed
gsmiller opened this issue May 20, 2023 · 1 comment · Fixed by #12427
Closed

DaciukMihovAutomatonBuilder#build should probably take a List instead of a Collection #12319

gsmiller opened this issue May 20, 2023 · 1 comment · Fixed by #12427
Labels
type:enhancement
Milestone
9.9.0

Comments

@gsmiller
Copy link
Contributor

Description

DaciukMihovAutomatonBuilder#build requires sorted input but accepts a Collection argument. Since Collection generally doesn't guarantee any ordering as part of its contract, we probably ought to use a List.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
9.9.0
Development

Successfully merging a pull request may close this issue.

StringsToAutomaton#build to take List as parameter instead of Collection shubhamvishu/lucene
2 participants
@gsmiller @shubhamvishu