Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make faster ToParentBlockJoinQuery.explain() #12269

Open
mkhludnev opened this issue May 5, 2023 · 3 comments
Open

Try to make faster ToParentBlockJoinQuery.explain() #12269

mkhludnev opened this issue May 5, 2023 · 3 comments

Comments

@mkhludnev
Copy link
Member

mkhludnev commented May 5, 2023

Description

It's a spin off from #12204 #12245.
I'm not sure it's really necessary, please advise.
Now ToParentBlockJoinQuery.BlockJoinScorer#explain requests expensive explain() for every matching child doc. Here are possible measures:
2. call score() in the beginning of explain(), use returned score to find child doc (for Min,Max modes)
3. drag child scorer over block to count matches
4. request explain() only for the child found at 2.

WDYD?

@MarcusSorealheis
Copy link
Contributor

it can be implemented, but how much effort into explain performance at this time. I don't think now is the time to address this aspect of a feature that has been broken for years and remains broken.

@MarcusSorealheis
Copy link
Contributor

it's a great idea, though. There's likely higher priority work, even in ToParentBlockJoinQuery.

@mkhludnev
Copy link
Member Author

also, worth to fix 963ed7c#r112890793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants