We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, long-manager builds too many objects like FlinkConfiguration, FlinkService, and FlinkOperation when building and managing Flink jobs. The reason is, that for every single access of these classes, the manager creates a new object. See: https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkService.java#?L73~L75
FlinkConfiguration
FlinkService
FlinkOperation
public FlinkService(String endpoint) throws Exception { FlinkConfiguration flinkConfiguration = new FlinkConfiguration(); flinkConfig = flinkConfiguration.getFlinkConfig();
https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/listener/StartupSortListener.java#L143~L144
FlinkService flinkService = new FlinkService(flinkInfo.getEndpoint()); FlinkOperation flinkOperation = new FlinkOperation(flinkService);
InLong Manager
The text was updated successfully, but these errors were encountered:
aloyszhang
Successfully merging a pull request may close this issue.
Description
Currently, long-manager builds too many objects like
FlinkConfiguration
,FlinkService
, andFlinkOperation
when building and managing Flink jobs.The reason is, that for every single access of these classes, the manager creates a new object.
See:
https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkService.java#?L73~L75
https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/listener/StartupSortListener.java#L143~L144
InLong Component
InLong Manager
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: