Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Optimize BatchPackProfile related classes implementation #8161

Closed
2 tasks done
gosonzhang opened this issue Jun 6, 2023 · 0 comments · Fixed by #8187
Closed
2 tasks done

[Improve][DataProxy] Optimize BatchPackProfile related classes implementation #8161

gosonzhang opened this issue Jun 6, 2023 · 0 comments · Fixed by #8187

Comments

@gosonzhang
Copy link
Contributor

Description

In the current sink implementation, the event is obtained from the channel and is ready to be sent. V1 messages need to be sent in batches but V0 messages do not. Sink uses BatchPackProfile and its subclasses SimpleBatchPackProfileV0 and OrderBatchPackProfileV0 for corresponding processing.

From the analysis of the implementation, this class can be optimized, by defining an abstract class, the common attributes and operations of the three classes, BatchPackProfile, SimpleBatchPackProfileV0, and OrderBatchPackProfileV0, are extracted, and then the events of V0 and V1 are processed separately, which can simplify the current implementation.

This issue is for this category improvement

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment