You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current sink implementation, the event is obtained from the channel and is ready to be sent. V1 messages need to be sent in batches but V0 messages do not. Sink uses BatchPackProfile and its subclasses SimpleBatchPackProfileV0 and OrderBatchPackProfileV0 for corresponding processing.
From the analysis of the implementation, this class can be optimized, by defining an abstract class, the common attributes and operations of the three classes, BatchPackProfile, SimpleBatchPackProfileV0, and OrderBatchPackProfileV0, are extracted, and then the events of V0 and V1 are processed separately, which can simplify the current implementation.
Description
In the current sink implementation, the event is obtained from the channel and is ready to be sent. V1 messages need to be sent in batches but V0 messages do not. Sink uses BatchPackProfile and its subclasses SimpleBatchPackProfileV0 and OrderBatchPackProfileV0 for corresponding processing.
From the analysis of the implementation, this class can be optimized, by defining an abstract class, the common attributes and operations of the three classes, BatchPackProfile, SimpleBatchPackProfileV0, and OrderBatchPackProfileV0, are extracted, and then the events of V0 and V1 are processed separately, which can simplify the current implementation.
This issue is for this category improvement
InLong Component
InLong DataProxy
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: