Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Optimize the implementation logic of the Source #7950

Closed
2 tasks done
gosonzhang opened this issue Apr 28, 2023 · 0 comments · Fixed by #8041
Closed
2 tasks done

[Improve][DataProxy] Optimize the implementation logic of the Source #7950

gosonzhang opened this issue Apr 28, 2023 · 0 comments · Fixed by #8041

Comments

@gosonzhang
Copy link
Contributor

Description

At present, there are several problems in the Source:

  1. InLongMsg V0 and V1 versions use two similar implementations for processing, and here we consider merging them for easy maintenance and management;
  2. Consider extracting the common implementations of HTTP, TCP, and UDP on the source side, if there are other different encoding schemes, you only need to implement the corresponding MessageFactory and MessageHandler, and the related protocol Source processing does not need to be changed, which is convenient for other protocol extensions;
  3. Adjust relevant implementation code, optimize logic, and supplement test cases

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants