Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Manager] Support field description when parsing field by JSON #7893

Closed
2 tasks done
featzhang opened this issue Apr 22, 2023 · 0 comments · Fixed by #7894
Closed
2 tasks done

[Feature][Manager] Support field description when parsing field by JSON #7893

featzhang opened this issue Apr 22, 2023 · 0 comments · Fixed by #7894

Comments

@featzhang
Copy link
Member

Description

The current JSON format can not specify field comments:

[
  { "fid": "int"  },
  { "ftitle": "string"  },
  { "fcontent": "string"  },
  { "fcreates_time": "timestamp"  }
]

Change the format of JSON to the following format:

[
  {
    "name": "fid",
    "type": "int",
    "desc": "news id"
  },
  {
    "name": "ftitle",
    "type": "string",
    "desc": "news title"
  },
  {
    "name": "fcontent",
    "type": "string",
    "desc": "news content"
  },
  {
    "name": "fcreates_time",
    "type": "timestamp",
    "desc": "news created time, in format 'yyyy-MM-dd HH:mm:ss'"
  }

Use case

No response

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@dockerzhang dockerzhang added this to the 1.7.0 milestone Apr 22, 2023
@healchow healchow changed the title [Feature][Manager] Support field desciption when parse field by json [Feature][Manager] Support field description when parsing field by JSON Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants