Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SceSim Editor saved file can not be run as mvn clean verify #1807

Open
Tracked by #453
jomarko opened this issue Feb 7, 2025 · 4 comments · May be fixed by apache/incubator-kie-drools#6254
Open
Tracked by #453

New SceSim Editor saved file can not be run as mvn clean verify #1807

jomarko opened this issue Feb 7, 2025 · 4 comments · May be fixed by apache/incubator-kie-drools#6254
Assignees
Labels
area:dmn Related to DMN area:test-scenario Related to Test Scenario (scesim) area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly

Comments

@jomarko
Copy link

jomarko commented Feb 7, 2025

This issue belongs to the epic #453. Without this issue the New SceSim editor can not be assumed as matured and Classic SceSim editor needs to be kept.

Steps to reproduce - existing scesim

  1. Please open dmn-quarkus-example project, use main branch (https://github.com/apache/incubator-kie-kogito-examples/tree/main/kogito-quarkus-examples/dmn-quarkus-example)
  2. run mvn clean verify - it will pass 🟢
  3. open the single .scesim file using New SceSim editor
  4. Edit some given data cell and save the file
  5. run mvn clean verify - it will fail, what is kind of expected, however with an error, that indicates that some exception was thrown before test evaluation. in other words, user is not informed what was expected and what was actual result.. User receives just some exception log 🔴 [1]

Steps to reproduce - fresh scesim

I also struggle to run fresh scesim created from scratch. The tested DMN model is ismple id or print function, it just takes one input and returns it unchanged. Trying to run a sceism for similar dmn causing [2]

[1]

[ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.816 s <<< FAILURE! -- in testscenario.KogitoScenarioJunitActivatorTest
[ERROR] TrafficViolationTest.#1: Above speed limit: more than 30 km/h -- Time elapsed: 0.524 s <<< ERROR!
org.drools.scenariosimulation.backend.runner.IndexedScenarioException: #1 Above speed limit: more than 30 km/h: Error in GIVEN data (TrafficViolationTest)
        at org.drools.scenariosimulation.backend.runner.AbstractScenarioRunner.defineFailureException(AbstractScenarioRunner.java:144)
        at org.drools.scenariosimulation.backend.runner.AbstractScenarioRunner.singleRunScenario(AbstractScenarioRunner.java:127)
        at org.drools.scenariosimulation.backend.runner.AbstractScenarioRunner.run(AbstractScenarioRunner.java:103)
        at org.kogito.scenariosimulation.runner.KogitoJunitActivator.runChild(KogitoJunitActivator.java:35)
        at org.kogito.scenariosimulation.runner.KogitoJunitActivator.runChild(KogitoJunitActivator.java:26)
Caused by: org.drools.scenariosimulation.backend.runner.ScenarioException: Error in GIVEN data
        at org.drools.scenariosimulation.backend.runner.AbstractRunnerHelper.extractGivenValues(AbstractRunnerHelper.java:164)
        at org.drools.scenariosimulation.backend.runner.AbstractRunnerHelper.run(AbstractRunnerHelper.java:84)
        at org.drools.scenariosimulation.backend.runner.AbstractScenarioRunner.internalRunScenario(AbstractScenarioRunner.java:150)
        at org.drools.scenariosimulation.backend.runner.AbstractScenarioRunner.singleRunScenario(AbstractScenarioRunner.java:124)
        ... 3 more

[2]

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.019 s <<< FAILURE! -- in testscenario.KogitoScenarioJunitActivatorTest
[ERROR] testscenario.KogitoScenarioJunitActivatorTest -- Time elapsed: 0.009 s <<< ERROR!
org.drools.scenariosimulation.backend.runner.ScenarioException: Issue on parsing file: /home/jomarko/incubator-kie-kogito-examples/kogito-quarkus-examples/dmn-quarkus-example/target/test-classes/a.scesim
        at org.drools.scenariosimulation.backend.runner.ScenarioJunitActivator.parseFile(ScenarioJunitActivator.java:87)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1707)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
        at org.drools.scenariosimulation.backend.runner.ScenarioJunitActivator.getChildren(ScenarioJunitActivator.java:64)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1602)
        at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
        at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
Caused by: java.lang.IllegalArgumentException: Impossible to extract version from the file
        at org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistence.extractVersion(ScenarioSimulationXMLPersistence.java:193)
        at org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistence.migrateIfNecessary(ScenarioSimulationXMLPersistence.java:150)
        at org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistence.unmarshal(ScenarioSimulationXMLPersistence.java:144)
        at org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistence.unmarshal(ScenarioSimulationXMLPersistence.java:136)
        at org.drools.scenariosimulation.backend.runner.ScenarioJunitActivator.parseFile(ScenarioJunitActivator.java:82)
        ... 17 more
@jomarko jomarko added area:dmn Related to DMN area:test-scenario Related to Test Scenario (scesim) area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly labels Feb 7, 2025
@yesamer yesamer self-assigned this Feb 7, 2025
@yesamer
Copy link

yesamer commented Feb 7, 2025

@jomarko Thank you, this is indeed a blocker for the final release., I'll fix it.

@jomarko
Copy link
Author

jomarko commented Feb 7, 2025

thank you @yesamer for looking into this

@yesamer
Copy link

yesamer commented Feb 7, 2025

Case 1 is fixed in apache/incubator-kie-tools#2887

@yesamer
Copy link

yesamer commented Feb 13, 2025

Case 2 is fixed in apache/incubator-kie-drools#6254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dmn Related to DMN area:test-scenario Related to Test Scenario (scesim) area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants