From e597e18afaf4fdde99f30da0e8e235147b708883 Mon Sep 17 00:00:00 2001 From: glutenperfbot Date: Thu, 14 Nov 2024 21:00:12 +0000 Subject: [PATCH 1/2] [GLUTEN-6887][VL] Daily Update Velox Version (2024_11_15) Signed-off-by: glutenperfbot --- ep/build-velox/src/get_velox.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ep/build-velox/src/get_velox.sh b/ep/build-velox/src/get_velox.sh index 06a7215d827a..9e0f3c0160ff 100755 --- a/ep/build-velox/src/get_velox.sh +++ b/ep/build-velox/src/get_velox.sh @@ -17,7 +17,7 @@ set -exu VELOX_REPO=https://github.com/oap-project/velox.git -VELOX_BRANCH=2024_11_14 +VELOX_BRANCH=2024_11_15 VELOX_HOME="" OS=`uname -s` From 995443312b2bb94149785096406d19b02a9db6cc Mon Sep 17 00:00:00 2001 From: Yuan Zhou Date: Fri, 15 Nov 2024 08:12:47 +0800 Subject: [PATCH 2/2] fix velox FileSystem API Signed-off-by: Yuan Zhou --- cpp/velox/jni/JniFileSystem.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/velox/jni/JniFileSystem.cc b/cpp/velox/jni/JniFileSystem.cc index 21cdf2b23a02..fa849664e3ae 100644 --- a/cpp/velox/jni/JniFileSystem.cc +++ b/cpp/velox/jni/JniFileSystem.cc @@ -241,7 +241,7 @@ class FileSystemWrapper : public facebook::velox::filesystems::FileSystem { return fs_->list(rewrite(path)); } - void mkdir(std::string_view path) override { + void mkdir(std::string_view path, const facebook::velox::filesystems::DirectoryOptions& options = {}) override { fs_->mkdir(rewrite(path)); } @@ -349,7 +349,7 @@ class JniFileSystem : public facebook::velox::filesystems::FileSystem { return out; } - void mkdir(std::string_view path) override { + void mkdir(std::string_view path, const facebook::velox::filesystems::DirectoryOptions& options = {}) override { JNIEnv* env = nullptr; attachCurrentThreadAsDaemonOrThrow(vm, &env); env->CallVoidMethod(obj_, jniFileSystemMkdir, createJString(env, path));