Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tree explain for ValuesExec #15093

Closed
Tracked by #14914
Shreyaskr1409 opened this issue Mar 8, 2025 · 6 comments
Closed
Tracked by #14914

Implement tree explain for ValuesExec #15093

Shreyaskr1409 opened this issue Mar 8, 2025 · 6 comments
Assignees

Comments

@Shreyaskr1409
Copy link
Contributor

Is your feature request related to a problem or challenge?

part of #14914

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

I have also taken work for #15089 but I thought working on issues similar to the ones which were solved would be easier to start with.

@Shreyaskr1409
Copy link
Contributor Author

take

@Shreyaskr1409
Copy link
Contributor Author

@irenjj , as per #14032 ValuesExec is deprecated. I tried running some simple queries which I thought would work like:

explain VALUES (1);

when I tried running it, I got the following results:

+   logical_plan Values: (Int64(1))
+   physical_plan
+   01)┌───────────────────────────┐
+   02)│       DataSourceExec      │
+   03)│    --------------------   │
+   04)│         bytes: 128        │
+   05)│       format: memory      │
+   06)│          rows: 1          │
+   07)└───────────────────────────┘

Could this be because of the deprecation? Is there something which I could do to figure out why this isn't working out?

@irenjj
Copy link
Contributor

irenjj commented Mar 8, 2025

#14032

Hi, @Shreyaskr1409 , maybe we don't need to implement the explain format since it's deprecated. cc @jonathanc-n .
I've noticed you've picked other tasks, maybe we can implement others first.❤️

@Shreyaskr1409
Copy link
Contributor Author

Shreyaskr1409 commented Mar 8, 2025

@irenjj Yes, now I am working on the other JsonSink task after this. Actually I am new to this repository so I though it would have been easier to perform the simpler task as you already made some PRs which I did follow but this became the harder one to understand as I just found this was deprecated.

Maybe we should remove ValuesExec part from #14914 as it is no longer needed. Anyways, thank you!

@Shreyaskr1409
Copy link
Contributor Author

Shreyaskr1409 commented Mar 8, 2025

please feel free to close this issue if there is no other input. Edit: This comment automatically closed this issue, I did not know there was automation set up.

@irenjj
Copy link
Contributor

irenjj commented Mar 8, 2025

@irenjj Yes, now I am working on the other JsonSink task after this. Actually I am new to this repository so I though it would have been easier to perform the simpler task as you already made some PRs which I did follow but this became the harder one to understand as I just found this was deprecated.

Maybe we should remove ValuesExec part from #14914 as it is no longer needed. Anyways, thank you!

Thank you for your work! Feel free to reach out to me if you have any questions.❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants