Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WindowUDFImpl::reverse_expr + support for IGNORE NULLS #12661

Closed
jcsherin opened this issue Sep 28, 2024 · 0 comments · Fixed by #12662
Closed

Add WindowUDFImpl::reverse_expr + support for IGNORE NULLS #12661

jcsherin opened this issue Sep 28, 2024 · 0 comments · Fixed by #12662
Labels
enhancement New feature or request

Comments

@jcsherin
Copy link
Contributor

jcsherin commented Sep 28, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

  1. Reverse a user-defined window function which computes the same result but in the reverse order.
  2. Add support for IGNORE NULLS when creating user-defined window expressions.

Describe the solution you'd like

  1. Add a new trait method WindowUDFImpl::reverse_expr.
  2. Add is_reversed state field to WindowUDFExpr to know if the expression is reversed.
  3. Add ignore_nulls state field to WindowUDFExpr.

Describe alternatives you've considered

No response

Additional context

Part of #8709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds WindowUDFImpl::reverse_exprtrait method + Support for IGNORE NULLS jcsherin/datafusion
1 participant
@jcsherin