Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default httpd.max_http_request_size consistent #1304

Closed
garethbowen opened this issue Apr 30, 2018 · 4 comments
Closed

Make default httpd.max_http_request_size consistent #1304

garethbowen opened this issue Apr 30, 2018 · 4 comments

Comments

@garethbowen
Copy link

garethbowen commented Apr 30, 2018

The httpd.max_http_request_size defaults to 64MB. However if the value is unset it defaults to 4GB 1, 2, 3, 4, 5. Also I interpreted the documentation to say it defaults to 4GB (though the default isn't explicitly stated).

Expected Behavior

Users expectations are met.

Current Behavior

Users get surprised by the actual default value.

Possible Solution

Either:

  1. the default.ini should be updated to 4GB (or commented out) to be consistent with the fallback values and documentation, or
  2. the fallback values and documentation should be updated to 64MB to be consistent with the default.ini value

Your Environment

@wohali
Copy link
Member

wohali commented May 1, 2018

We're resolving this differently in 2.2.0 - the entire semantic will change because of underlying issues.

See #1200 and #1253 on what is changing.

@wohali wohali closed this as completed May 1, 2018
@wohali
Copy link
Member

wohali commented May 1, 2018

FYI you should never modify default.ini, this file is intentionally updated with each release and sometimes doesn't match defaults set in the code.

This is why the default is 64MB in the ini file but different in the actual code...

@garethbowen
Copy link
Author

@wohali Thanks for that. Do you think it'd be worth updating the documentation? It looks like this value will continue to default to 64MB through v3.0 and it would be helpful to specify that instead of 4GB as it does currently.

@wohali
Copy link
Member

wohali commented May 1, 2018

@garethbowen #1253 is tagged to be resolved in 2.2.0 in some form. I will make sure that we update the documentation as part of that effort in some regard, since this is a big change with forward-looking ramifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants