Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Python SDK installation cannot generate proto with protobuf 3.20.2 #23227

Closed
Abacn opened this issue Sep 14, 2022 · 5 comments
Closed

Comments

@Abacn
Copy link
Contributor

Abacn commented Sep 14, 2022

What happened?

All python suites (actions / Jenkins) fail with:

15:41:07 Processing ./target/.tox-py38-docs/.tmp/package/1/apache-beam-2.43.0.dev0.zip
15:41:07   Preparing metadata (setup.py): started
15:41:07   Preparing metadata (setup.py): finished with status 'error'
15:41:07   error: subprocess-exited-with-error
15:41:07   
15:41:07   × python setup.py egg_info did not run successfully.
15:41:07   │ exit code: 1
15:41:07   ╰─> [10 lines of output]
15:41:07       Traceback (most recent call last):
15:41:07         File "<string>", line 2, in <module>
15:41:07         File "<pip-setuptools-caller>", line 34, in <module>
15:41:07         File "/tmp/pip-req-build-rgi4y61h/setup.py", line 169, in <module>
15:41:07           generate_protos_first()
15:41:07         File "/tmp/pip-req-build-rgi4y61h/setup.py", line 139, in generate_protos_first
15:41:07           gen_protos.generate_proto_files()
15:41:07         File "/tmp/pip-req-build-rgi4y61h/gen_protos.py", line 476, in generate_proto_files
15:41:07           raise RuntimeError(error_msg)
15:41:07       RuntimeError: Not in apache git tree, unable to find proto definitions.
15:41:07       [end of output]
15:41:07   
15:41:07   note: This error originates from a subprocess, and is likely not a problem with pip.
15:41:07 error: metadata-generation-failed
15:41:07 
15:41:07 × Encountered error while generating package metadata.
15:41:07 ╰─> See above for output.

### Issue Priority

Priority: 1

### Issue Component

Component: test-failures
@tvalentyn
Copy link
Contributor

Thanks, do we have a bug on protobuf side?

@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2022

Thanks, do we have a bug on protobuf side?

Raised protocolbuffers/protobuf#10564

@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2022

From protobuf 3.20.1 to 3.20.2 do not find something strange: protocolbuffers/protobuf@v3.20.1...v3.20.2 the change is really minor, mostly fixing macos build.

From Beam side, looks like the build "python/build/apache-beam.tar.gz" sent to tox does not contain generated code anymore, which triggers this error.

@Abacn
Copy link
Contributor Author

Abacn commented Sep 15, 2022

.take-issue

@Abacn
Copy link
Contributor Author

Abacn commented Sep 15, 2022

.close-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants