Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Enable object name linter #29189

Open
asfimport opened this issue Aug 3, 2021 · 0 comments
Open

[R] Enable object name linter #29189

asfimport opened this issue Aug 3, 2021 · 0 comments

Comments

@asfimport
Copy link
Collaborator

We don't currently even try to use the object name lintr because identifying the S3 methods isn't quite right for Arrow in lintr. The basics of this is that we should be able to do something like head.ArrowClassName <- function() but if the head bit isn't correctly identified as an S3 method, lintr will complain thinking we are mixing dots and camel case. There are a number of different ways this doesn't fully work (see below). Once those are resolved, we should be able to enable an object name linter as well

A few PRs + issues around this:
r-lib/lintr#843
r-lib/lintr#841
r-lib/lintr#842
r-lib/lintr#846

Reporter: Jonathan Keane / @jonkeane

Note: This issue was originally created as ARROW-13537. Please see the migration documentation for further details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants