Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement append_n for BooleanBuilder #6634

Closed
jayzhan211 opened this issue Oct 28, 2024 · 1 comment · Fixed by #6646
Closed

Implement append_n for BooleanBuilder #6634

jayzhan211 opened this issue Oct 28, 2024 · 1 comment · Fixed by #6646
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@jayzhan211
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Describe the solution you'd like

It has potential to improve the speed if we want to append n false

Currently, we can only do append_slice.

    #[inline]
    pub fn append_slice(&mut self, v: &[bool]) {
        self.values_builder.append_slice(v);
        self.null_buffer_builder.append_n_non_nulls(v.len());
    }

If we want to append n false, the first line code can be ignored, since it only appends value if it is true

Describe alternatives you've considered

Additional context

Could be helpful for apache/datafusion#13134

@alamb
Copy link
Contributor

alamb commented Nov 16, 2024

label_issue.py automatically added labels {'arrow'} from #6646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants