Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BinaryView in arrow_string::length #6358

Closed
Omega359 opened this issue Sep 5, 2024 · 2 comments · Fixed by #6359
Closed

Add support for BinaryView in arrow_string::length #6358

Omega359 opened this issue Sep 5, 2024 · 2 comments · Fixed by #6359
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@Omega359
Copy link
Contributor

Omega359 commented Sep 5, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Add support for binary view in the length fn. This was brought up in a code review in #6345

Describe the solution you'd like

Code, tests added for calculating length for binary view.

Describe alternatives you've considered

Do not implement.

Additional context

@Omega359 Omega359 added the enhancement Any new improvement worthy of a entry in the changelog label Sep 5, 2024
@Omega359
Copy link
Contributor Author

Omega359 commented Sep 5, 2024

take

@alamb
Copy link
Contributor

alamb commented Oct 2, 2024

label_issue.py automatically added labels {'arrow'} from #6345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants