Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BufUploader to implement same feature upon WriteMultipart like BufWriter #5834

Closed
Xuanwo opened this issue Jun 3, 2024 · 1 comment · Fixed by #5835
Closed

Add BufUploader to implement same feature upon WriteMultipart like BufWriter #5834

Xuanwo opened this issue Jun 3, 2024 · 1 comment · Fixed by #5835
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jun 3, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

During implementing #5766, I find a missing piece of our current API set:

BufWriter adaptively uses put or put_multipart, depending on the volume of data written. However, there is no native implementation for PutPayload. This forces users to either use BufWriter, which requires an extra copy, or manually implement the adaptive logic.

Describe the solution you'd like

I plan to introduce BufUploader that fill this gap.

Describe alternatives you've considered

None.

Additional context

The PR has been sunmitted at #5835.

@Xuanwo Xuanwo added the enhancement Any new improvement worthy of a entry in the changelog label Jun 3, 2024
@alamb alamb added the object-store Object Store Interface label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'object-store'} from #5835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants