Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Support #1495

Open
tustvold opened this issue Mar 28, 2022 · 0 comments
Open

Logging Support #1495

tustvold opened this issue Mar 28, 2022 · 0 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 28, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently arrow and parquet do not have any log instrumentation, and I have frequently found myself adding logging to track down a problem, only to then have to remove this logging for the final PR.

Describe the solution you'd like

This log crate is well-supported within the Rust ecosystem and allows filtering out callsites at both runtime and compile time. It is also used downstream by DataFusion. This would allow adding instrumentation to the code that can be enabled for debugging a problem, and then disabled when no longer desired.

Describe alternatives you've considered

There is also the tracing ecosystem, but this is likely significant overkill given neither crate makes significant use of tokio. Fortunately tracing-log provides an adapter should a downstream wish to use tokio-tracing, whilst allowing arrow, etc... to use the significantly simpler log ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant