Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Add support for verifying .{asc,sha256,512} for .jar related files in dev/release/verify_rc.sh #593

Open
kou opened this issue Feb 7, 2025 · 3 comments
Labels
Type: enhancement New feature or request

Comments

@kou
Copy link
Member

kou commented Feb 7, 2025

Describe the enhancement requested

We should:

  • Download binary artifacts from GitHub Release
  • Verify signature by gpg --verify XXX.asc XXX
  • Verify checksum by sha256 -c XXX.sha256 and sha512 -c XXX.sha512
@kou kou added the Type: enhancement New feature or request label Feb 7, 2025
@jbonofre
Copy link
Member

From an ASF standpoint, the most important is to verify the source distribution from dist.apache.org.
So, maybe we can verify artifacts from GitHub Release, but also from dist.apache.org.

Do you want me to give it a shoot ?

@kou
Copy link
Member Author

kou commented Feb 13, 2025

Oh, really!?
https://www.apache.org/legal/release-policy.html#host-rc uses "SHOULD":

Projects should use the /dev tree of the dist repository or the staging features of repository.apache.org to host release candidates posted for developer testing/voting (prior to being, potentially, formally blessed as a GA release).

So, I thought that we can use other ASF approved locations such as Artifactory https://apache.jfrog.io/ and GitHub Release.

@jbonofre
Copy link
Member

@kou for staging, it's fine, we can use GitHub Release location. As we also push to dist.apache.org (release location, not dev after release), it's OK.

@kou so you are right, GitHub Release is good enough for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants