Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Implement arrow-memory-ffm #163

Open
danepitkin opened this issue Sep 15, 2023 · 5 comments
Open

[Java] Implement arrow-memory-ffm #163

danepitkin opened this issue Sep 15, 2023 · 5 comments
Assignees

Comments

@danepitkin
Copy link
Member

danepitkin commented Sep 15, 2023

Describe the enhancement requested

Add a memory module that uses the java.lang.foreign module (currently in preview, APIs updated in Java 21).

When using Java 9 or later with the current implementations, some JDK internals must be exposed by adding --add-opens=java.base/java.nio=ALL-UNNAMED to the java command[1]. Here's an article that explains the general Java issue here[2].

Can using java.lang.foreign remove this dependency so users do not have to run with custom options ?

[1]https://arrow.apache.org/docs/java/install.html#java-compatibility
[2]https://community.snowflake.com/s/article/JDBC-Driver-Compatibility-Issue-With-JDK-16-and-Later

Component(s)

Java

@lidavidm
Copy link
Member

Not until Java 21+ (or really Java 24, when the new memory APIs will presumably be stabilized)

@lidavidm
Copy link
Member

Also, this is a runtime flag, not a build flag

@danepitkin
Copy link
Member Author

Ah I see. Updated to reference runtime now. Shall I close this given this won't happen any time soon?

@lidavidm
Copy link
Member

The interesting things to me would be (1) implementing an arrow-memory-ffm that uses the experimental API so we can figure out how well it works and (2) refactoring BufferAllocator and other core APIs to be in line with the new upstream APIs so that when Java 24 comes, we're ready

@lidavidm
Copy link
Member

Because if something is missing for us it's kinda too late to communicate any feedback upstream

@danepitkin danepitkin changed the title [Java] Remove dependency on JDK internals in Java 9+ [Java] Implement arrow-memory-ffm Sep 28, 2023
@assignUser assignUser transferred this issue from apache/arrow Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants