From d1d000fa9555046e701d824d90514f776543ea1d Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Fri, 25 Mar 2022 09:06:48 +0100 Subject: [PATCH] Fix mocking the right method in secret backend test The #22348 introduced a change on how connections are retrieved from secret backends, but one of the tests has not been changed to follow. This fixes failing main. --- tests/secrets/test_secrets.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/secrets/test_secrets.py b/tests/secrets/test_secrets.py index 83a7fe3a383ac..f8d8a6717cd63 100644 --- a/tests/secrets/test_secrets.py +++ b/tests/secrets/test_secrets.py @@ -94,10 +94,10 @@ def test_backends_kwargs(self): ) @mock.patch( "airflow.providers.amazon.aws.secrets.systems_manager." - "SystemsManagerParameterStoreBackend.get_conn_uri" + "SystemsManagerParameterStoreBackend.get_connection" ) - def test_backend_fallback_to_env_var(self, mock_get_uri): - mock_get_uri.return_value = None + def test_backend_fallback_to_env_var(self, mock_get_connection): + mock_get_connection.return_value = None backends = ensure_secrets_loaded() backend_classes = [backend.__class__.__name__ for backend in backends] @@ -106,7 +106,7 @@ def test_backend_fallback_to_env_var(self, mock_get_uri): conn = Connection.get_connection_from_secrets(conn_id="test_mysql") # Assert that SystemsManagerParameterStoreBackend.get_conn_uri was called - mock_get_uri.assert_called_once_with(conn_id='test_mysql') + mock_get_connection.assert_called_once_with(conn_id='test_mysql') assert 'mysql://airflow:airflow@host:5432/airflow' == conn.get_uri()