Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect asset name attribute when accessing inlet and outlet events #44601

Closed
3 tasks done
Lee-W opened this issue Dec 3, 2024 · 1 comment · Fixed by #44639
Closed
3 tasks done

Respect asset name attribute when accessing inlet and outlet events #44601

Lee-W opened this issue Dec 3, 2024 · 1 comment · Fixed by #44639
Assignees
@Lee-W
Labels
AIP-74 Dataset -> Asset area:datasets Issues related to the datasets feature kind:feature Feature Requests

Comments

@Lee-W
Copy link
Member

Lee-W commented Dec 3, 2024 •
edited
Loading

Description

AIP-74 introduces the name attribute to the asset, while the outlet_events and inlet_events only respect the URI attribute. This needs to be fixed

  • additional todo
    • Mark AssetAliasEvent as private and move it to airflow/utils/context.py

Use case/motivation

No response

Related issues

#43956

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Lee-W Lee-W added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Dec 3, 2024
@Lee-W Lee-W self-assigned this Dec 3, 2024
@Lee-W Lee-W removed the needs-triage label for new issues that we didn't triage yet label Dec 3, 2024
@dosubot dosubot bot added the area:datasets Issues related to the datasets feature label Dec 3, 2024
@Lee-W Lee-W changed the title Repect asset name attribue when accessing inlet and outlet events Respect asset name attribue when accessing inlet and outlet events Dec 3, 2024
@Lee-W Lee-W changed the title Respect asset name attribue when accessing inlet and outlet events Respect asset name attribute when accessing inlet and outlet events Dec 3, 2024
@phanikumv phanikumv moved this from Ready to In progress in AIP-74 Introducing Data Assets Dec 4, 2024
@Lee-W
Copy link
Member Author

Lee-W commented Dec 4, 2024

#44639

@Lee-W Lee-W added the AIP-74 Dataset -> Asset label Dec 5, 2024
@Lee-W Lee-W moved this from In progress to Ready in AIP-74 Introducing Data Assets Dec 5, 2024
@Lee-W Lee-W moved this from Ready to In review in AIP-74 Introducing Data Assets Dec 5, 2024
@Lee-W Lee-W mentioned this issue Dec 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in AIP-74 Introducing Data Assets Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lee-W Lee-W

Labels
AIP-74 Dataset -> Asset area:datasets Issues related to the datasets feature kind:feature Feature Requests
Projects
AIP-74 Introducing Data Assets
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect Asset.name when accessing inlet and outlet events astronomer/airflow
1 participant
@Lee-W