Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve mypy errors on appflow #44111

Closed
1 task done
eladkal opened this issue Nov 17, 2024 · 1 comment · Fixed by #44115
Closed
1 task done

Resolve mypy errors on appflow #44111

eladkal opened this issue Nov 17, 2024 · 1 comment · Fixed by #44115
Assignees
@jx2lee
Labels
area:providers good first issue kind:meta High-level information important to the community provider:amazon AWS/Amazon - related issues

Comments

@eladkal
Copy link
Contributor

eladkal commented Nov 17, 2024 •
edited
Loading

Body

Following #42954 (comment) and #43436 we need to fix the issue with mypy-boto3-appflow and remove the type ignores.

The task:

  1. Bump to mypy-boto3-appflo>=1.35.39
  2. Apply the needed fixes to appflow code to make mypy happy without using # type: ignore[arg-type]

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added provider:amazon AWS/Amazon - related issues area:providers good first issue kind:meta High-level information important to the community labels Nov 17, 2024
@dosubot dosubot bot added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Nov 17, 2024
@eladkal eladkal removed the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Nov 17, 2024
@jx2lee
Copy link
Contributor

jx2lee commented Nov 17, 2024

@eladkal Can i take this issue? assign to me, please 🚀

@jx2lee jx2lee mentioned this issue Nov 17, 2024
Merged
@eladkal eladkal mentioned this issue Dec 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jx2lee jx2lee

Labels
area:providers good first issue kind:meta High-level information important to the community provider:amazon AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump to mypy-boto3-appflow and pass without # type: ignore[arg-type] jx2lee/airflow
2 participants
@eladkal @jx2lee