Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of parameters in WebUI #35944

Closed
2 tasks done
glasen opened this issue Nov 29, 2023 · 8 comments
Closed
2 tasks done

Wrong order of parameters in WebUI #35944

glasen opened this issue Nov 29, 2023 · 8 comments
Assignees
Labels
affected_version:2.7 Issues Reported for 2.7 area:core area:UI Related to UI/UX. For Frontend Developers. Can't Reproduce The problem cannot be reproduced good first issue kind:bug This is a clearly a bug pending-response stale Stale PRs per the .github/workflows/stale.yml policy file

Comments

@glasen
Copy link

glasen commented Nov 29, 2023

Apache Airflow version

2.7.3

What happened

Please see the provided code and the screenshot:

with (DAG( 'sag_pipeline_4_ai', default_args=default_args, description='KI-Pipeline', schedule_interval=None, start_date=pendulum.today('UTC').add(), tags=['sag'], max_active_runs=1, params={ "database": create_list_param(URIServer.get_all_databases(), "Select Database"), "collection": create_list_param(["messages", "files_content"], "Select Collection"), "server": create_list_param(['mia', 'akira', 'tori'], "Select Server"), "epochs_document_embedding": Param(10, type="integer", minimum=3, maximum=30, title="Epochs for document-embedding"), "force_cleaning": Param(False, type="boolean", title="Force cleaning"), "build_topic_model": Param(True, type="boolean", title="Build Topic-Model"), "rebuild_communication_graph": Param(False, type="boolean", title="Rebuild communication-graph"), "purge_persons_communication_graph": Param(True, type="boolean", title="Purge persons from communication-graph"), } ) as dag):

Screenshot

The ordering of the params in the UI is different from the ordering in the code.

What you think should happen instead

According to your documentation, the ordering should be like the ordering in the code:

Use Params to Provide a Trigger UI Form

Form fields are rendered in the order of definition of params in the DAG.

How to reproduce

Fresh pip-install of Airflow 2.3.7 on Ubuntu 22.04 with Python 3.10.

Operating System

Ubuntu 22.04

Versions of Apache Airflow Providers

No response

Deployment

Virtualenv installation

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@glasen glasen added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Nov 29, 2023
Copy link

boring-cyborg bot commented Nov 29, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@RNHTTR RNHTTR added area:UI Related to UI/UX. For Frontend Developers. good first issue and removed needs-triage label for new issues that we didn't triage yet labels Dec 29, 2023
@ardada2468
Copy link

Can I start working on this?

@potiuk
Copy link
Member

potiuk commented Jan 31, 2024

sure

@eladkal eladkal added the affected_version:2.7 Issues Reported for 2.7 label Feb 1, 2024
@huruifeng
Copy link

this also happens to me, I am using 2.8.0, the ordering of the parameters in WebUI is totally different from the ordering in code?
Has this been solved or how can I order my parameters in the WebUI.

@glasen
Copy link
Author

glasen commented Feb 8, 2024

The problem still exists with version 2.8.1

@simond
Copy link
Contributor

simond commented Mar 3, 2024

I can't seem to replicate this on 2.8.1 - are you able to provide a minimal working example? Your code example is unfinished.

@eladkal eladkal added Can't Reproduce The problem cannot be reproduced pending-response labels Mar 6, 2024
Copy link

This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 21, 2024
Copy link

This issue has been closed because it has not received response from the issue author.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.7 Issues Reported for 2.7 area:core area:UI Related to UI/UX. For Frontend Developers. Can't Reproduce The problem cannot be reproduced good first issue kind:bug This is a clearly a bug pending-response stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

No branches or pull requests

7 participants