Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for standard SQL in BigQueryGetDataOperator #31109

Closed
2 tasks done
shahar1 opened this issue May 6, 2023 · 2 comments · Fixed by #31190
Closed
2 tasks done

Add support for standard SQL in BigQueryGetDataOperator #31109

shahar1 opened this issue May 6, 2023 · 2 comments · Fixed by #31190
Assignees
Labels
area:providers kind:feature Feature Requests provider:google Google (including GCP) related issues

Comments

@shahar1
Copy link
Contributor

shahar1 commented May 6, 2023

Description

Currently, the BigQueryGetDataOperator always utilizes legacy SQL when submitting jobs (set as the default by the BQ API). This approach may cause problems when using standard SQL features, such as names for projects, datasets, or tables that include hyphens (which is very common nowadays). We would like to make it configurable, so users can set a flag in the operator to enable the use of standard SQL instead.

Use case/motivation

When implementing #30887 to address #24460, I encountered some unusual errors, which were later determined to be related to the usage of hyphens in the GCP project ID name.

Related issues

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@shahar1 shahar1 added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels May 6, 2023
@pierrejeambrun pierrejeambrun added area:providers provider:google Google (including GCP) related issues and removed needs-triage label for new issues that we didn't triage yet labels May 6, 2023
@pierrejeambrun
Copy link
Member

Thanks for reporting, just assigned you :)

@shahar1
Copy link
Contributor Author

shahar1 commented May 6, 2023

Thanks for reporting, just assigned you :)

No problem :)
I've already solved it in #30887, but I was asked to move the related changes to a separate PR (for clarity).
I am waiting for the former to be merged, and then I'll create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:feature Feature Requests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants