Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow 2.3.0 does not keep promised backward compatibility regarding database configuration using _CMD Env #23408

Closed
1 of 2 tasks
c-thiel opened this issue May 2, 2022 · 1 comment
Labels
area:core kind:bug This is a clearly a bug

Comments

@c-thiel
Copy link
Contributor

c-thiel commented May 2, 2022

Apache Airflow version

2.3.0 (latest released)

What happened

We used to configure the Database using the AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD Environment variable.
Now the config option moved from CORE to DATABASE. However, we intended to keep backward compatibility as stated in the Release Notes.

Upon 2.3.0 update however, the _CMD suffixed variables are no longer recognized for database configuration in Core - I think due to a missing entry here:

('database', 'sql_alchemy_conn'),

What you think should happen instead

We should only get a deprecation warning but the Database should be configured correctly.

How to reproduce

Configure Airflow using an external Database using the AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD environment variable. Notice that Airflow falls back to SQLight.

Operating System

kubernetes

Versions of Apache Airflow Providers

No response

Deployment

Other 3rd-party Helm chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@c-thiel c-thiel added area:core kind:bug This is a clearly a bug labels May 2, 2022
@c-thiel c-thiel changed the title Airflow 2.3.0 does not keep promised backward compatibility regarding database configuration using __CMD Airflow 2.3.0 does not keep promised backward compatibility regarding database configuration using _CMD Env May 2, 2022
@potiuk
Copy link
Member

potiuk commented May 2, 2022

Indeed seems like a bug. Would you like to submit a PR fixing it @c-thiel ? Seems like an easy fix - and you could become one of the > 2000 contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

3 participants