Skip to content

Commit aaf29ee

Browse files
authored
Remove reparse on DAG depending on asset alias (#44866)
I suspect we no longer need this since alias resolution now happens very late in the scheduling process. A DAG *should* be able to automatically understand the alias is resolved without a reparse after refactorings introduced in cccc933.
1 parent 707c564 commit aaf29ee

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

airflow/assets/manager.py

-5
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,6 @@ def register_asset_change(
174174
if alias_ref.dag.is_active and not alias_ref.dag.is_paused
175175
}
176176

177-
dags_to_reparse = dags_to_queue_from_asset_alias - dags_to_queue_from_asset
178-
if dags_to_reparse:
179-
file_locs = {dag.fileloc for dag in dags_to_reparse}
180-
cls._send_dag_priority_parsing_request(file_locs, session)
181-
182177
cls.notify_asset_changed(asset=asset)
183178

184179
Stats.incr("asset.updates")

tests/assets/test_manager.py

-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
DagScheduleAssetReference,
3535
)
3636
from airflow.models.dag import DagModel
37-
from airflow.models.dagbag import DagPriorityParsingRequest
3837
from airflow.sdk.definitions.asset import Asset, AssetAlias
3938

4039
from tests.listeners import asset_listener
@@ -139,7 +138,6 @@ def test_register_asset_change_with_alias(self, session, dag_maker, mock_task_in
139138
# Ensure we've created an asset
140139
assert session.query(AssetEvent).filter_by(asset_id=asm.id).count() == 1
141140
assert session.query(AssetDagRunQueue).count() == 2
142-
assert session.query(DagPriorityParsingRequest).count() == 2
143141

144142
def test_register_asset_change_no_downstreams(self, session, mock_task_instance):
145143
asset_manager = AssetManager()

0 commit comments

Comments
 (0)