From 70d6e589d61c46876583dd77fc4772331db67025 Mon Sep 17 00:00:00 2001 From: Alex Pyattaev Date: Mon, 30 Dec 2024 11:02:44 +0000 Subject: [PATCH 1/2] eliminate some obviously useless threading --- perf/src/sigverify.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/perf/src/sigverify.rs b/perf/src/sigverify.rs index e07da9bcecf732..ac9fb799f7eb03 100644 --- a/perf/src/sigverify.rs +++ b/perf/src/sigverify.rs @@ -490,9 +490,9 @@ pub fn ed25519_verify_cpu(batches: &mut [PacketBatch], reject_non_vote: bool, pa pub fn ed25519_verify_disabled(batches: &mut [PacketBatch]) { let packet_count = count_packets_in_batches(batches); debug!("disabled ECDSA for {}", packet_count); - batches.into_par_iter().for_each(|batch| { + batches.iter_mut().for_each(|batch| { batch - .par_iter_mut() + .iter_mut() .for_each(|p| p.meta_mut().set_discard(false)) }); } From f6ec641d86186c3994a45c3473175fb0feb7184e Mon Sep 17 00:00:00 2001 From: Alex Pyattaev Date: Thu, 2 Jan 2025 18:59:21 +0200 Subject: [PATCH 2/2] make disabled version of ed25519_verify use threading correctly --- perf/src/sigverify.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/perf/src/sigverify.rs b/perf/src/sigverify.rs index ac9fb799f7eb03..89ba49c59a376d 100644 --- a/perf/src/sigverify.rs +++ b/perf/src/sigverify.rs @@ -490,10 +490,10 @@ pub fn ed25519_verify_cpu(batches: &mut [PacketBatch], reject_non_vote: bool, pa pub fn ed25519_verify_disabled(batches: &mut [PacketBatch]) { let packet_count = count_packets_in_batches(batches); debug!("disabled ECDSA for {}", packet_count); - batches.iter_mut().for_each(|batch| { - batch - .iter_mut() - .for_each(|p| p.meta_mut().set_discard(false)) + PAR_THREAD_POOL.install(|| { + batches.par_iter_mut().flatten().for_each(|packet| { + packet.meta_mut().set_discard(false); + }); }); }