Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted capitalization of query name in examples in 1.0.5 #277

Closed
simoncoggins opened this issue Apr 5, 2022 · 3 comments · Fixed by #282
Closed

Unwanted capitalization of query name in examples in 1.0.5 #277

simoncoggins opened this issue Apr 5, 2022 · 3 comments · Fixed by #282

Comments

@simoncoggins
Copy link
Contributor

I've been experimenting with the 1.0 release, which is really excellent! We are looking to use SpectaQL for our docs and the release is really timely as it allows us to do the customisation we want without forking (both themes and the data customisation are exactly what we wanted). Thank you for all the great work!

I've spotted a few changes/issues from the previous version when we run it on our schema. I'll create separate tickets for each, but to start: I noticed you now capitalize the first letter of the query name automatically here:

const query = `${prefix} ${capitalizeFirstLetter(field.name)}${

For us this isn't ideal as we use snake_case query names so it looks a bit odd and is inconsistent with what shows up on the row below:

Screen Shot 2022-04-05 at 8 11 41 PM

Is there a reason for forcing to a capital letter? Any chance of putting it back how it was or making it optional?

@simoncoggins
Copy link
Contributor Author

That's perfect, thank you!

@newhouse
Copy link
Collaborator

newhouse commented Apr 5, 2022

Should be fixed in 1.0.8.

@simoncoggins
Copy link
Contributor Author

Tested in 1.0.9 and it's fixed. Defaults to no change to query name but you can set to a few different strategies in config.yml and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants