Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #2090

Closed
wants to merge 1 commit into from
Closed

Update readme.md #2090

wants to merge 1 commit into from

Conversation

mohamedation
Copy link

added give.do logo

added give.do logo
@vercel
Copy link

vercel bot commented Oct 2, 2022

@mohamedation is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

@mohamedation Thanks for your PR. I, however, don't think this is needed since the image is shown using the current URL. I think it is simply protected against direct access in the browser.

Give india logo
<a href="https://indiafightscorona.giveindia.org">
<img src="https://d2wvdrxmr8p0wf.cloudfront.net/static/giveindia.svg" alt="Give India logo" width="200" />
</a>

@rickstaa rickstaa closed this Oct 2, 2022
@mohamedation
Copy link
Author

@rickstaa oh,my mistake then. It's not showing for me and I thought it's an issue.
Sorry for the inconvenience.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

@mohamedation Oh in that case maybe mine is showing because it is cached.

@rickstaa rickstaa reopened this Oct 2, 2022
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 97.41% // Head: 97.41% // No change to project coverage 👍

Coverage data is based on head (5c65084) compared to base (6f8bd9f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2090   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          22       22           
  Lines        3481     3481           
  Branches      316      316           
=======================================
  Hits         3391     3391           
  Misses         89       89           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Thanks for letting me know I fixed it with an earlier PR #2085.

@rickstaa rickstaa closed this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants