Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing color on top language card #2513

Closed
tranghane opened this issue Feb 11, 2023 · 6 comments
Closed

Changing color on top language card #2513

tranghane opened this issue Feb 11, 2023 · 6 comments
Labels
enhancement New feature or request. lang-card Issues related to the language card.

Comments

@tranghane
Copy link

Is your feature request related to a problem? Please describe.

image
The colour for JuppyterNotebook and HTML are red and orange which make it's kinda hard to see, wonder if I can change that

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@tranghane tranghane added the enhancement New feature or request. label Feb 11, 2023
@Zo-Bro-23
Copy link
Collaborator

Zo-Bro-23 commented Feb 11, 2023

It is definitely possible to change the colors, since #2409 implements this. We can consider adding this feature if it gets enough upvotes. If you can develop the feature yourself (you can use #2409 as guidance), please do so, and I will review the pull request!

@rickstaa what do you think?

@Zo-Bro-23 Zo-Bro-23 added the lang-card Issues related to the language card. label Feb 11, 2023
@Zo-Bro-23
Copy link
Collaborator

The colour for JuppyterNotebook and HTML are red and orange which make it's kinda hard to see

PS: I'm colorblind (protan), so they're literally the same for me. Will definitely consider the feature!

@rickstaa
Copy link
Collaborator

@tranghane Thanks for your feature request. I agree with @Zo-Bro-23. Let's track this feature in #2479.

@rickstaa rickstaa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2023
@tranghane
Copy link
Author

Thank you so much~~

@rickstaa
Copy link
Collaborator

rickstaa commented Feb 13, 2023

Thank you so much~~

No problem. You can also request a colour change at https://github.com/github/linguist. It might be faster since we have a lot of other more pressing issues and PRs. 👍

@Zo-Bro-23
Copy link
Collaborator

Thank you so much~~

No problem. You can also request a colour change at https://github.com/github/linguist. It might be faster since we have a lot of other more pressing issues and PRs. +1

Like I mentioned in #2479, this will not be a permanent solution due to the number of colors linguist supports. It could be a good solution, though, since a lot of people use both Jupyter and HTML. Changing the color might also break backward compatibility though, so I'm not sure if they will approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. lang-card Issues related to the language card.
Projects
None yet
Development

No branches or pull requests

3 participants