Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(line): 折线图支持区域填充 #2939

Merged
merged 2 commits into from
Oct 23, 2021
Merged

feat(line): 折线图支持区域填充 #2939

merged 2 commits into from
Oct 23, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Oct 23, 2021 •
edited
Loading

PR includes

Screenshot

Before After
❌

需要注意的是：多折线图，默认不堆叠。因此添加区域填充说的时候，会出现 area 遮挡现象（这是正常现象）

isStack: false isStack: true
image image

@visiky visiky requested a review from hustcc October 23, 2021 04:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2021 •
edited
Loading

🎊 PR Preview f9730c5 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2939.surge.sh?type=diff&date=2021-10-23

🕐 Build time: 137.201s

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Oct 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1374824712

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 95.253%
Files with Coverage Reduction New Missed Lines %
src/plots/line/adaptor.ts 5 87.23%
Totals Coverage Status
Change from base Build 1374668446: 0.002%
Covered Lines: 6815
Relevant Lines: 6956
💛 - Coveralls

@visiky visiky changed the title feat(line): 折线图支持区域填充 wip: feat(line): 折线图支持区域填充 Oct 23, 2021
@visiky visiky changed the title wip: feat(line): 折线图支持区域填充 feat(line): 折线图支持区域填充 Oct 23, 2021
@visiky
Copy link
Member Author

visiky commented Oct 23, 2021

本地 CI 已过

@visiky visiky merged commit 45cd61d into master Oct 23, 2021
@visiky visiky deleted the feat-line branch October 23, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc Awaiting requested review from hustcc

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

折线图区域填充
2 participants
@visiky @coveralls