Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add contributors #2635

Merged
merged 3 commits into from
Jun 15, 2021
Merged

chore: add contributors #2635

merged 3 commits into from
Jun 15, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jun 12, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

后续的话，直接呼叫机器人🤖添加即可, Usage

Before After
❌ image

accesslint[bot]
accesslint bot suggested changes Jun 12, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@visiky visiky changed the title chore: add contributors wip: chore: add contributors Jun 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2021 •
edited
Loading

🎊 PR Preview 839cbd0 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2635.surge.sh?type=diff&date=2021-06-15

🕐 Build time: 88.11s

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jun 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 938664836

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.056%
Totals Coverage Status
Change from base Build 930578592: 0.0%
Covered Lines: 5981
Relevant Lines: 6075
💛 - Coveralls

@visiky visiky force-pushed the init-contributors branch from 374e879 to dd269cf Compare June 13, 2021 00:10
accesslint[bot]
accesslint bot approved these changes Jun 13, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@visiky visiky force-pushed the init-contributors branch from dd269cf to 1e178de Compare June 13, 2021 00:30
accesslint[bot]
accesslint bot approved these changes Jun 13, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Jun 13, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@visiky visiky force-pushed the init-contributors branch from 55c8955 to 31d8f36 Compare June 13, 2021 00:35
accesslint[bot]
accesslint bot approved these changes Jun 13, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@visiky visiky changed the title wip: chore: add contributors chore: add contributors Jun 13, 2021
@visiky visiky requested a review from hustcc June 13, 2021 00:40
@visiky visiky force-pushed the init-contributors branch from 31d8f36 to 9164db9 Compare June 15, 2021 04:17
accesslint[bot]
accesslint bot approved these changes Jun 15, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@hustcc
Copy link
Member

hustcc commented Jun 15, 2021

.github/ISSUE_TEMPLATE.md 这个怎么删除了~

@visiky
Copy link
Member Author

visiky commented Jun 15, 2021

.github/ISSUE_TEMPLATE.md 这个怎么删除了~

有一个目录夹了，这个还需要？

@visiky visiky force-pushed the init-contributors branch from 9164db9 to 839cbd0 Compare June 15, 2021 08:50
accesslint[bot]
accesslint bot approved these changes Jun 15, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@visiky visiky merged commit 5a55e73 into master Jun 15, 2021
@visiky visiky deleted the init-contributors branch June 15, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc left review comments

@accesslint accesslint[bot] accesslint[bot] approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc