Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sunburst 重构和优化 #2603

Merged
merged 10 commits into from
Jun 4, 2021
Merged

refactor: sunburst 重构和优化 #2603

merged 10 commits into from
Jun 4, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jun 2, 2021 •
edited
Loading

PR includes

  1. 修复展示问题（不使用 ignoreParentValues，会导致真的无法使用了，类似 矩阵树图 也需要修复 @liuzhenying ）
  2. 暴露内置字段：path, depth, height 等
  3. Tooltip: 展示优化。默认展示路径
  4. Label: 展示优化。默认不开启，开启默认展示节点名称
  5. Color: 默认跟随祖先节点，随层级增加逐渐降低透明度
  6. Breaking change: 废除 seriesField, 通过 hierarchyConfig.field 替代
  7. Docs: 文档和 demo 完善

Screenshot

Before After
image
image
image

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021 •
edited
Loading

🎊 PR Preview 552667b has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2603.surge.sh?type=diff&date=2021-06-04

🕐 Build time: 89.065s

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jun 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 905711995

  • 56 of 56 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 96.344%
Totals Coverage Status
Change from base Build 895839182: 0.07%
Covered Lines: 5661
Relevant Lines: 5736
💛 - Coveralls

@visiky visiky changed the title wip: refactor: sunburst 重构和优化 refactor: sunburst 重构和优化 Jun 4, 2021
@visiky visiky requested review from lxfu1 and hustcc June 4, 2021 06:45
@visiky visiky mentioned this pull request Jun 4, 2021
Closed
3 tasks
@visiky
Copy link
Member Author

visiky commented Jun 4, 2021

close: #2570

@visiky visiky merged commit 70bab7c into master Jun 4, 2021
@visiky visiky deleted the enhance-sunburst branch June 4, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

旭日图：显示bug
3 participants
@visiky @coveralls @hustcc